gitea/go-sdk
45
46
Fork 73
Code Issues 21 Pull Requests 6 Actions Releases 19 Activity

GetFile: Use "ref" in-query if posible #491

Merged
6543 merged 9 commits from 6543/go-sdk:GetFile_use-ref_in-query_if-posible into master 2021-02-16 20:07:45 +00:00
Conversation 0 Commits 9 Files Changed 2 +57 -13
6543 commented 2021-02-16 11:33:00 +00:00
Owner
Copy Link

based on https://github.com/go-gitea/gitea/pull/14563

based on https://github.com/go-gitea/gitea/pull/14563
6543 added this to the v0.14.0 milestone 2021-02-16 11:33:00 +00:00
6543 added the
kind/enhancement
 label 2021-02-16 11:33:00 +00:00
6543 added 1 commit 2021-02-16 11:33:01 +00:00
GetFile: use ref in-query if posible
All checks were successful
continuous-integration/drone/pr Build is passing
Details
0b46b13343
6543 added 1 commit 2021-02-16 14:36:34 +00:00
GetFile: test with ref="" and ref not default branch
All checks were successful
continuous-integration/drone/pr Build is passing
Details
42dfc52e3d
6543 added 1 commit 2021-02-16 14:47:44 +00:00
bytes.Equal
All checks were successful
continuous-integration/drone/pr Build is passing
Details
58f3add627
zeripath reviewed 2021-02-16 15:45:52 +00:00
Dismissed
gitea/repo_file.go Outdated
@ -122,0 +121,4 @@
if c.checkServerVersionGreaterThanOrEqual(version1_14_0) != nil {
return c.getResponse("GET", fmt.Sprintf("/repos/%s/%s/raw/%s/%s", owner, repo, ref, tree), nil, nil)
}
return c.getResponse("GET", fmt.Sprintf("/repos/%s/%s/raw/%s?ref=%s", owner, repo, tree, ref), nil, nil)
zeripath commented 2021-02-16 15:45:52 +00:00
Owner
Copy Link

tree and ref should both be escaped properly.

ref is simple as it's url.QueryEscape but tree needs escaping using the partial pathescape.

tree and ref should both be escaped properly. ref is simple as it's url.QueryEscape but tree needs escaping using the partial pathescape.
6543 marked this conversation as resolved
6543 added 1 commit 2021-02-16 16:51:49 +00:00
QueryEscape
All checks were successful
continuous-integration/drone/pr Build is passing
Details
c60731a1f2
techknowlogick approved these changes 2021-02-16 17:02:15 +00:00
Dismissed
6543 added 1 commit 2021-02-16 17:49:05 +00:00
extreme test branch naming
All checks were successful
continuous-integration/drone/pr Build is passing
Details
e1bfd1ce6f
6543 added 1 commit 2021-02-16 18:00:42 +00:00
test content itselve too
All checks were successful
continuous-integration/drone/pr Build is passing
Details
c2b7a504b9
zeripath reviewed 2021-02-16 18:13:22 +00:00
Dismissed
gitea/repo_file.go Outdated
@ -122,0 +122,4 @@
if c.checkServerVersionGreaterThanOrEqual(version1_14_0) != nil {
return c.getResponse("GET", fmt.Sprintf("/repos/%s/%s/raw/%s/%s", owner, repo, ref, tree), nil, nil)
}
return c.getResponse("GET", fmt.Sprintf("/repos/%s/%s/raw/%s?ref=%s", owner, repo, tree, url.QueryEscape(ref)), nil, nil)
zeripath commented 2021-02-16 18:13:22 +00:00
Owner
Copy Link

tree needs to be util.PathEscapeSegments or something like it.

e.g. from Gitea modules/util

// PathEscapeSegments escapes segments of a path while not escaping forward slash
func PathEscapeSegments(path string) string {
	slice := strings.Split(path, "/")
	for index := range slice {
		slice[index] = url.PathEscape(slice[index])
	}
	escapedPath := strings.Join(slice, "/")
	return escapedPath
}

as does ref and tree on line 123

tree needs to be `util.PathEscapeSegments` or something like it. e.g. from Gitea modules/util ``` // PathEscapeSegments escapes segments of a path while not escaping forward slash func PathEscapeSegments(path string) string { slice := strings.Split(path, "/") for index := range slice { slice[index] = url.PathEscape(slice[index]) } escapedPath := strings.Join(slice, "/") return escapedPath } ``` as does ref and tree on line 123
6543 commented 2021-02-16 18:20:49 +00:00
Author
Owner
Copy Link

this is a more genneral issue witch I like to catch with #273 since we need this not only for this function...

this is a more genneral issue witch I like to catch with #273 since we need this not only for this function...
6543 marked this conversation as resolved
6543 added 1 commit 2021-02-16 19:22:41 +00:00
pathEscapeSegments
All checks were successful
continuous-integration/drone/pr Build is passing
Details
12c4dc167b
6543 added 2 commits 2021-02-16 19:39:43 +00:00
Test: use strange file name
All checks were successful
continuous-integration/drone/pr Build is passing
Details
c19c73c06b
zeripath approved these changes 2021-02-16 19:51:46 +00:00
Dismissed
6543 merged commit 32b0722f98 into master 2021-02-16 20:07:45 +00:00
6543 deleted branch GetFile_use-ref_in-query_if-posible 2021-02-16 20:07:52 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
has/backport

   
has/pull

   
in progress

   
invalid

   
kind/breaking

   
kind/bug

   
kind/build

   
kind/deployment

   
kind/docs

   
kind/enhancement

   
kind/feature

   
kind/lint

   
kind/proposal

   
kind/question

   
kind/refactor

   
kind/security

   
kind/testing

   
kind/translation

   
kind/ui

   
need/backport

   
priority/critical

   
priority/low

   
priority/maybe

   
priority/medium

   
reviewed/duplicate

   
reviewed/invalid

   
reviewed/wontfix

   
skip-changelog

   
status/blocked

   
status/needs-feedback

   
status/needs-reviews

   
status/wip

   
upstream/gitea
No Label
has/backport
has/pull
in progress
invalid
kind/breaking
kind/bug
kind/build
kind/deployment
kind/docs
kind/enhancement
kind/feature
kind/lint
kind/proposal
kind/question
kind/refactor
kind/security
kind/testing
kind/translation
kind/ui
need/backport
priority/critical
priority/low
priority/maybe
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
Milestone
Clear milestone
No items
No Milestone
v0.14.0
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/go-sdk#491
No description provided.
Delete Branch "6543/go-sdk:GetFile_use-ref_in-query_if-posible"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?