gitea/go-sdk
45
46
Fork 73
Code Issues 21 Pull Requests 6 Actions Releases 19 Activity

Make Client thread-safe & add docs #495

Merged
6543 merged 6 commits from :doc-concurrency into master 2021-03-04 20:19:56 +00:00
Conversation 3 Commits 6 Files Changed 4 +68 -21
noerw commented 2021-03-03 06:57:11 +00:00
Member
Copy Link

fix #494

fix #494
noerw added 1 commit 2021-03-03 06:57:12 +00:00
docs: mention thread-safeness
All checks were successful
continuous-integration/drone/pr Build is passing
Details
c0e50a6b46
6543 added 1 commit 2021-03-03 23:04:48 +00:00
use mutex
All checks were successful
continuous-integration/drone/pr Build is passing
Details
7084a556a9
6543 changed title from docs: mention Client thread-safeness to Make Client thread-safe & add docs 2021-03-04 00:07:52 +00:00
6543 added the
kind/docs
 label 2021-03-04 00:08:02 +00:00
6543 added 1 commit 2021-03-04 00:15:10 +00:00
simplify & finish
All checks were successful
continuous-integration/drone/pr Build is passing
Details
969df574f9
6543 added the
kind/enhancement
 label 2021-03-04 00:16:25 +00:00
6543 added this to the v0.14.0 milestone 2021-03-04 00:16:29 +00:00
6543 added 1 commit 2021-03-04 12:53:51 +00:00
get client ref within thread-save code
All checks were successful
continuous-integration/drone/pr Build is passing
Details
6e7f81a3a6
6543 approved these changes 2021-03-04 12:55:02 +00:00
Dismissed
noerw commented 2021-03-04 12:55:43 +00:00
Author
Member
Copy Link

lgtm

lgtm
🎉 1
lunny commented 2021-03-04 16:00:11 +00:00
Owner
Copy Link

We could add -race flag on ci test and also add a test with two goroutines to use the client.

We could add -race flag on ci test and also add a test with two goroutines to use the client.
👍 1
6543 commented 2021-03-04 18:13:30 +00:00
Owner
Copy Link

@lunny @jolheiser we already do!

https://gitea.com/gitea/go-sdk/src/branch/master/Makefile#L77

@lunny @jolheiser we already do! https://gitea.com/gitea/go-sdk/src/branch/master/Makefile#L77
6543 added 1 commit 2021-03-04 18:15:26 +00:00
same with c.debug
All checks were successful
continuous-integration/drone/pr Build is passing
Details
308a9e73ca
6543 added 1 commit 2021-03-04 18:24:50 +00:00
find posible race cond outside client.go
All checks were successful
continuous-integration/drone/pr Build is passing
Details
1b45e79cf6
6543 approved these changes 2021-03-04 18:25:13 +00:00
Dismissed
6543 left a comment
Owner
Copy Link

this should it finaly be :O

this should it finaly be :O
zeripath approved these changes 2021-03-04 20:15:17 +00:00
Dismissed
zeripath left a comment
Owner
Copy Link

OK I think this is right.

It might be helpful to extract a small core struct that has the functions that use internal fields and hence need to be locked.

That way you can be sure that the locking is correct - at present there are so so many functions that ensuring that they are always safe will be hard.

OK I think this is right. It might be helpful to extract a small core struct that has the functions that use internal fields and hence need to be locked. That way you can be sure that the locking is correct - at present there are so so many functions that ensuring that they are always safe will be hard.
6543 merged commit ff82113459 into master 2021-03-04 20:19:56 +00:00
6543 deleted branch doc-concurrency 2021-03-04 20:20:16 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
has/backport

   
has/pull

   
in progress

   
invalid

   
kind/breaking

   
kind/bug

   
kind/build

   
kind/deployment

   
kind/docs

   
kind/enhancement

   
kind/feature

   
kind/lint

   
kind/proposal

   
kind/question

   
kind/refactor

   
kind/security

   
kind/testing

   
kind/translation

   
kind/ui

   
need/backport

   
priority/critical

   
priority/low

   
priority/maybe

   
priority/medium

   
reviewed/duplicate

   
reviewed/invalid

   
reviewed/wontfix

   
skip-changelog

   
status/blocked

   
status/needs-feedback

   
status/needs-reviews

   
status/wip

   
upstream/gitea
No Label
has/backport
has/pull
in progress
invalid
kind/breaking
kind/bug
kind/build
kind/deployment
kind/docs
kind/enhancement
kind/feature
kind/lint
kind/proposal
kind/question
kind/refactor
kind/security
kind/testing
kind/translation
kind/ui
need/backport
priority/critical
priority/low
priority/maybe
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
Milestone
Clear milestone
No items
No Milestone
v0.14.0
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/go-sdk#495
No description provided.
Delete Branch ":doc-concurrency"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?