gitea/helm-chart
45
54
Fork 127
Code Issues 32 Pull Requests 7 Actions Releases 87 Activity

Format all files with prettier VSCode plugin and add yamllint in CI #413

Merged
pat-s merged 10 commits from format-files into main 2023-03-28 21:18:23 +00:00
Conversation 6 Commits 10 Files Changed 8 +134 -104
pat-s commented 2023-03-09 16:32:47 +00:00
Member
Copy Link

@justusbunsi to end my formatting mess... ;)

I am not fully sure myself about the linebreaks in values.yaml but I don't think there's an easy way to change that behavior.

@justusbunsi to end my formatting mess... ;) I am not fully sure myself about the linebreaks in `values.yaml` but I don't think there's an easy way to change that behavior.
pat-s added 1 commit 2023-03-09 16:32:48 +00:00
format all files with prettier
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
8d0a04b484
6543 commented 2023-03-21 02:29:35 +00:00
Owner
Copy Link

@pat-s can we add a lint step to CI to ensure it stay like this?

@pat-s can we add a lint step to CI to ensure it stay like this?
pat-s added 1 commit 2023-03-21 08:59:55 +00:00
yamllint
Some checks failed
continuous-integration/drone/pr Build is failing
Details
continuous-integration/drone/push Build is failing
Details
66fc2fe7a9
pat-s commented 2023-03-21 09:00:19 +00:00
Author
Member
Copy Link

Good idea! https://github.com/cytopia/docker-yamllint looks promising to me. Let's see if I can get it configured quickly.

Good idea! https://github.com/cytopia/docker-yamllint looks promising to me. Let's see if I can get it configured quickly.
pat-s added 1 commit 2023-03-21 09:09:48 +00:00
yamllint
Some checks failed
continuous-integration/drone/pr Build is failing
Details
continuous-integration/drone/push Build is failing
Details
913acc8272
pat-s added 1 commit 2023-03-21 09:14:43 +00:00
trailing space
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
1855cfd214
pat-s changed title from Format all files with `prettier` VSCode plugin to Format all files with `prettier` VSCode plugin and add `yamllint` in CI 2023-03-21 09:15:13 +00:00
pat-s requested review from justusbunsi 2023-03-21 09:15:29 +00:00
pat-s commented 2023-03-21 09:16:39 +00:00
Author
Member
Copy Link

@6543 Not sure if it covers all cases but I don't have resources now to check for each edge case :)
I'd argue: "better than before" ?

@6543 Not sure if it covers all cases but I don't have resources now to check for each edge case :) I'd argue: "better than before" ?
pat-s added 1 commit 2023-03-21 12:35:49 +00:00
Merge branch 'main' into format-files
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
f276d3e2d1
pat-s added 2 commits 2023-03-21 15:55:23 +00:00
Merge branch 'format-files' of gitea.com:gitea/helm-chart into format-files
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
8e2dc6d7c1
justusbunsi approved these changes 2023-03-21 18:09:41 +00:00
justusbunsi left a comment
Member
Copy Link

LGTM

LGTM
pat-s requested review from techknowlogick 2023-03-25 10:14:37 +00:00
pat-s added 1 commit 2023-03-27 17:26:40 +00:00
Merge branch 'main' into format-files
All checks were successful
continuous-integration/drone/pr Build is passing
Details
continuous-integration/drone/push Build is passing
Details
4955be2ae5
pat-s added 1 commit 2023-03-28 19:02:49 +00:00
Merge branch 'main' into format-files
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
e4ddc02a71
justusbunsi reviewed 2023-03-28 19:25:17 +00:00
Chart.lock
@ -5,3 +2,1 @@
- name: postgresql
repository: oci://registry-1.docker.io/bitnamicharts
version: 12.2.6
- name: memcached
justusbunsi commented 2023-03-28 19:25:17 +00:00
Member
Copy Link

If possible, we should probably disable formatting autogenerated files like Chart.lock. A helm dependency update with actually updated dependency version will remove the indentation again.

If possible, we should probably disable formatting autogenerated files like _Chart.lock_. A `helm dependency update` with actually updated dependency version will remove the indentation again.
pat-s added the
kind
lint
 label 2023-03-28 20:04:02 +00:00
pat-s reviewed 2023-03-28 21:15:34 +00:00
Chart.lock
@ -5,3 +2,1 @@
- name: postgresql
repository: oci://registry-1.docker.io/bitnamicharts
version: 12.2.6
- name: memcached
pat-s commented 2023-03-28 21:15:28 +00:00
Author
Member
Copy Link

I think it's fine: the formatting is only targeting the indentation (which is off imo and according to the formatter).
The indentation is not changed when running helm dependency update.

So I think once we get the PR in, there shouldn't be any conflicts in this regard.

I think it's fine: the formatting is only targeting the indentation (which is off imo and according to the formatter). The indentation is not changed when running `helm dependency update`. So I think once we get the PR in, there shouldn't be any conflicts in this regard.
pat-s added 1 commit 2023-03-28 21:15:44 +00:00
Merge branch 'main' into format-files
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
7077a6a185
pat-s commented 2023-03-28 21:17:54 +00:00
Author
Member
Copy Link

@justusbunsi I'm gonna merge this so I don't have to rebase another dozen times :) If something is troubling us afterwards, we can still account/adapt.

@justusbunsi I'm gonna merge this so I don't have to rebase another dozen times :) If something is troubling us afterwards, we can still account/adapt.
pat-s merged commit 87c59b2fca into main 2023-03-28 21:18:23 +00:00
justusbunsi commented 2023-03-28 21:23:54 +00:00
Member
Copy Link

Alright. 👍

Regarding the helm dependency update: it won't change indentation when nothing has changed in chart.yaml. If this file has a change on the dependency version, the update command will rewrite the lock file and resets the manually changed indentation. I've tested those two cases prior to mentioning it. But thinking about it: since changing the dep version requires rewriting the lock file anyway, it's nothing to be concerned about.

Alright. 👍 Regarding the `helm dependency update`: it won't change indentation when nothing has changed in chart.yaml. If this file has a change on the dependency version, the update command will rewrite the lock file and resets the manually changed indentation. I've tested those two cases prior to mentioning it. But thinking about it: since changing the dep version requires rewriting the lock file anyway, it's nothing to be concerned about.
pat-s commented 2023-03-29 07:06:49 +00:00
Author
Member
Copy Link

Ah thanks, you're right, that's unfortunate (just tried it).

See #424 for a possible solution.

Ah thanks, you're right, that's unfortunate (just tried it). See #424 for a possible solution.
Sign in to join this conversation.
Reviewers
No reviewers
justusbunsi
techknowlogick
Labels
Clear labels   
has
backport

  
in progress

   
invalid
  
kind
breaking

  
kind
bug

  
kind
build

  
kind
dependency

  
kind
deployment

  
kind
docs

  
kind
enhancement

  
kind
feature

  
kind
lint

  
kind
proposal

  
kind
question

  
kind
refactor

  
kind
security

  
kind
testing

  
kind
translation

  
kind
ui

  
need
backport

  
priority
critical

  
priority
low

  
priority
maybe

  
priority
medium

  
reviewed
duplicate

  
reviewed
invalid

  
reviewed
wontfix

  
skip-changelog
  
status
blocked

  
status
needs-feedback

  
status
needs-reviews

  
status
wip

  
upstream
gitea

  
upstream
other

No Label
has
backport
in progress
invalid
kind
breaking
kind
bug
kind
build
kind
dependency
kind
deployment
kind
docs
kind
enhancement
kind
feature
kind
lint
kind
proposal
kind
question
kind
refactor
kind
security
kind
testing
kind
translation
kind
ui
need
backport
priority
critical
priority
low
priority
maybe
priority
medium
reviewed
duplicate
reviewed
invalid
reviewed
wontfix
skip-changelog
status
blocked
status
needs-feedback
status
needs-reviews
status
wip
upstream
gitea
upstream
other
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/helm-chart#413
No description provided.
Delete Branch "format-files"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?