gitea/helm-chart
48
54
Fork 129
Code Issues 30 Pull Requests 8 Actions Releases 88 Activity

Memcache: PROVIDER_CONFIG is not restored if altered previously #453

New Issue
Closed
opened 2023-06-02 10:13:30 +00:00 by pat-s · 5 comments
pat-s commented 2023-06-02 10:13:30 +00:00
Member
Copy Link

I just switched from redis-cluster to memcache and noticed that session.PROVIDER_CONFIG is not restored to the respective memcache DNS.

It is done for cache.HOST: https://gitea.com/gitea/helm-chart/src/branch/main/templates/_helpers.tpl#L233 and should most likely be done in the same way for session.PROVIDER_CONFIG.

I just switched from redis-cluster to memcache and noticed that `session.PROVIDER_CONFIG` is not restored to the respective memcache DNS. It is done for `cache.HOST`: https://gitea.com/gitea/helm-chart/src/branch/main/templates/_helpers.tpl#L233 and should most likely be done in the same way for `session.PROVIDER_CONFIG`.
pat-s added the
kind
bug
 label 2023-06-02 10:13:30 +00:00
justusbunsi commented 2023-06-02 11:38:26 +00:00
Member
Copy Link

Isn't that similar to #356?

Isn't that similar to #356?
pat-s commented 2023-06-02 11:43:03 +00:00
Author
Member
Copy Link

Partly as the old config is not removed when switching session providers but the actual issue is that the chart is not defining memcache for session.

I made the issue in a hurry and I just realized that the chart is (most likely on purpose) not setting anything for config.session. I thought the default was memcache there as well but now I am not sure anymore...

Partly as the old config is not removed when switching session providers but the actual issue is that the chart is not defining memcache for session. I made the issue in a hurry and I just realized that the chart is (most likely on purpose) not setting anything for `config.session`. I thought the default was `memcache` there as well but now I am not sure anymore...
justusbunsi commented 2023-06-02 11:46:31 +00:00
Member
Copy Link

I believe the chart uses the default for sessions. Which is memory.

I believe the chart uses the default for sessions. Which is memory.
pat-s commented 2023-06-04 07:52:04 +00:00
Author
Member
Copy Link

Good point. Then it's probably only #356 again and I should have set it to memory instead of memcache.

Given we already have memcache, it could also be used for session.

Good point. Then it's probably only #356 again and I should have set it to `memory` instead of `memcache`. Given we already have `memcache`, it could also be used for `session`.
pat-s commented 2023-11-15 18:26:41 +00:00
Author
Member
Copy Link

Closing in favor of #356.

Closing in favor of #356.
pat-s closed this issue 2023-11-15 18:26:42 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
has
backport

  
in progress

   
invalid
  
kind
breaking

  
kind
bug

  
kind
build

  
kind
dependency

  
kind
deployment

  
kind
docs

  
kind
enhancement

  
kind
feature

  
kind
lint

  
kind
proposal

  
kind
question

  
kind
refactor

  
kind
security

  
kind
testing

  
kind
translation

  
kind
ui

  
need
backport

  
priority
critical

  
priority
low

  
priority
maybe

  
priority
medium

  
reviewed
duplicate

  
reviewed
invalid

  
reviewed
wontfix

  
skip-changelog
  
status
blocked

  
status
needs-feedback

  
status
needs-reviews

  
status
wip

  
upstream
gitea

  
upstream
other

No Label
has
backport
in progress
invalid
kind
breaking
kind
bug
kind
build
kind
dependency
kind
deployment
kind
docs
kind
enhancement
kind
feature
kind
lint
kind
proposal
kind
question
kind
refactor
kind
security
kind
testing
kind
translation
kind
ui
need
backport
priority
critical
priority
low
priority
maybe
priority
medium
reviewed
duplicate
reviewed
invalid
reviewed
wontfix
skip-changelog
status
blocked
status
needs-feedback
status
needs-reviews
status
wip
upstream
gitea
upstream
other
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/helm-chart#453
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?