gitea/helm-chart
45
54
Fork 127
Code Issues 32 Pull Requests 7 Actions Releases 87 Activity

Resolve conflicting behavior during make readme #627

Merged
pat-s merged 1 commits from justusbunsi/helm-chart:readme-improvements into main 2024-03-15 16:02:09 +00:00
Conversation 0 Commits 1 Files Changed 2 +10 -10
justusbunsi commented 2024-03-10 18:42:54 +00:00
Member
Copy Link

The current README content is a result of running markdownlint with simple fixes enabled.
It shouldn't fix any issues, even after generating the parameter section.
Unfortunately, this is not the case right now.

This resolves the long-running dispute of both tools. 😉

Since I already modified the values.yaml, I decided to include a change regarding code signing.
Otherwise, it may confuse users after merging #596.

The current README content is a result of running markdownlint with simple fixes enabled. It shouldn't fix _any_ issues, even after generating the parameter section. Unfortunately, this is not the case right now. This resolves the long-running dispute of both tools. :wink: --- Since I already modified the `values.yaml`, I decided to include a change regarding code signing. Otherwise, it may confuse users after merging #596.
justusbunsi added the
kind
docs
 label 2024-03-10 18:42:54 +00:00
justusbunsi added 1 commit 2024-03-10 18:42:55 +00:00
Resolve conflicting behavior during make readme 
The current README content is a result of running markdownlint with
simple fixes enabled. It shouldn't fix _any_ issues, even after
generating the parameter section. Unfortunately, this is not the case
right now.

This resolves the dispute of both tools. 😉

---

Since I already modified the `values.yaml`, I decided to include a
change regarding code signing. Otherwise, it may confuse users after
merging #596.

Signed-off-by: justusbunsi <sk.bunsenbrenner@gmail.com>
All checks were successful
check-and-test / check-and-test (pull_request) Successful in 35s
Details
64676c9520
justusbunsi requested review from pat-s 2024-03-10 18:43:55 +00:00
pat-s approved these changes 2024-03-15 16:01:26 +00:00
pat-s merged commit 7fa896a0ce into main 2024-03-15 16:02:09 +00:00
justusbunsi deleted branch readme-improvements 2024-04-18 03:59:59 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
pat-s
Labels
Clear labels   
has
backport

  
in progress

   
invalid
  
kind
breaking

  
kind
bug

  
kind
build

  
kind
dependency

  
kind
deployment

  
kind
docs

  
kind
enhancement

  
kind
feature

  
kind
lint

  
kind
proposal

  
kind
question

  
kind
refactor

  
kind
security

  
kind
testing

  
kind
translation

  
kind
ui

  
need
backport

  
priority
critical

  
priority
low

  
priority
maybe

  
priority
medium

  
reviewed
duplicate

  
reviewed
invalid

  
reviewed
wontfix

  
skip-changelog
  
status
blocked

  
status
needs-feedback

  
status
needs-reviews

  
status
wip

  
upstream
gitea

  
upstream
other

No Label
has
backport
in progress
invalid
kind
breaking
kind
bug
kind
build
kind
dependency
kind
deployment
kind
docs
kind
enhancement
kind
feature
kind
lint
kind
proposal
kind
question
kind
refactor
kind
security
kind
testing
kind
translation
kind
ui
need
backport
priority
critical
priority
low
priority
maybe
priority
medium
reviewed
duplicate
reviewed
invalid
reviewed
wontfix
skip-changelog
status
blocked
status
needs-feedback
status
needs-reviews
status
wip
upstream
gitea
upstream
other
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/helm-chart#627
No description provided.
Delete Branch "justusbunsi/helm-chart:readme-improvements"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?