bug: when ingress.hosts
has one or more items, ROOT_URL
is conformed for ingress even though ingress.enabled
is false
#648
Labels
No Label
has
backport
in progress
invalid
kind
breaking
kind
bug
kind
build
kind
dependency
kind
deployment
kind
docs
kind
enhancement
kind
feature
kind
lint
kind
proposal
kind
question
kind
refactor
kind
security
kind
testing
kind
translation
kind
ui
need
backport
priority
critical
priority
low
priority
maybe
priority
medium
reviewed
duplicate
reviewed
invalid
reviewed
wontfix
skip-changelog
status
blocked
status
needs-feedback
status
needs-reviews
status
wip
upstream
gitea
upstream
other
No Milestone
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: gitea/helm-chart#648
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Discovered in version
1.21.11 built with GNU Make 4.4.1, go1.21.9 : bindata, timetzdata, sqlite, sqlite_unlock_notify
.Repro
modify values.xml with an
ingress
dict such as:and a
config.server
dict such as:Expected
Expected generated
app.ini
to contain aROOT_URL
value ofhttps://test.my-domain.com
.Actual
Actual generated
app.ini
contains aROOT_URL
value ofhttp://git.my-domain.com
.Notes
Within
_helpers.tpl
there appears a snippet such as this, which is what led me to realizing what was causing this behavior. I am not familiar enough with Helm templating to know that this is really root-cause, but, it is what led me to updating my values so the rollout generated a correctapp.ini
:Using the provided values I am not able to reproduce your issue. In my rendered files - either with current main branch, or latest release - I get the https ROOT_URL in app.ini.
Could you share your whole values.yaml (without sensitive information of course)