macaron/session
Archived
1
2
Fork 3
Code Issues Pull Requests Releases Wiki Activity

Update github.com/go-redis/redis to v6.15.2 #4

Merged
lunny merged 1 commits from :redis-6 into master 2019-08-01 01:31:19 +00:00
Conversation 12 Commits 1 Files Changed 4 +17 -24
tamalsaha commented 2019-07-31 02:01:50 +00:00
Contributor
Copy Link

This version supports Redis cluster. I have also added go.mod

Signed-off-by: Tamal Saha tamal@appscode.com

This version supports Redis cluster. I have also added go.mod Signed-off-by: Tamal Saha <tamal@appscode.com>
techknowlogick approved these changes 2019-07-31 02:06:13 +00:00
Dismissed
lunny commented 2019-07-31 02:10:56 +00:00
Contributor
Copy Link

@tamalsaha we cannot use travis because it don’t support gitea. We have https://drone.gitea.com and see my PR #3

@tamalsaha we cannot use travis because it don’t support gitea. We have https://drone.gitea.com and see my PR #3
tamalsaha commented 2019-07-31 02:17:51 +00:00
Author
Contributor
Copy Link

Removed travis.yml

Removed travis.yml
appleboy approved these changes 2019-07-31 02:59:18 +00:00
Dismissed
lunny requested changes 2019-07-31 03:01:11 +00:00
Dismissed
go.mod Outdated
@ -0,0 +1,34 @@
module github.com/go-macaron/session
lunny commented 2019-07-31 03:00:54 +00:00
Contributor

gitea.com

gitea.com
techknowlogick commented 2019-07-31 03:19:21 +00:00
Contributor
Copy Link

@lunny updated

@lunny updated
lunny reviewed 2019-07-31 03:21:30 +00:00
Dismissed
redis/redis.go Outdated
lunny commented 2019-07-31 03:21:30 +00:00
Contributor

wrong import package.

wrong import package.
lunny commented 2019-07-31 03:22:43 +00:00
Contributor
Copy Link

@techknowlogick I still think we should merge this after CI ready and we need your first PR to enable go mod at first.

@techknowlogick I still think we should merge this after CI ready and we need your first PR to enable go mod at first.
tamalsaha commented 2019-07-31 03:26:37 +00:00
Author
Contributor
Copy Link

I still think we should merge this after CI ready and we need your first PR to enable go mod at first.

I second that. Changing the module path touches almost all the files. I think it will be better to set the module support separately.

> I still think we should merge this after CI ready and we need your first PR to enable go mod at first. I second that. Changing the module path touches almost all the files. I think it will be better to set the module support separately.
betacat0 approved these changes 2019-07-31 04:00:57 +00:00
Dismissed
lunny commented 2019-07-31 04:41:08 +00:00
Contributor
Copy Link

@tamalsaha Please rebase.

@tamalsaha Please rebase.
tamalsaha commented 2019-07-31 08:23:51 +00:00
Author
Contributor
Copy Link

@lunny, I have rebased.

Should we also change the package path github.com/go-macaron/session => gitea.com/macaron/session ?

@lunny, I have rebased. Should we also change the package path `github.com/go-macaron/session` => `gitea.com/macaron/session` ?
lunny commented 2019-07-31 09:45:10 +00:00
Contributor
Copy Link

I think yes. @tamalsaha

I think yes. @tamalsaha
tamalsaha commented 2019-07-31 10:02:50 +00:00
Author
Contributor
Copy Link

@lunny, should I open a separate pr for the package name change?

@lunny, should I open a separate pr for the package name change?
lunny commented 2019-07-31 12:02:20 +00:00
Contributor
Copy Link

@tamalsaha that's another PR. If you can do that, would be great.

@tamalsaha that's another PR. If you can do that, would be great.
tamalsaha commented 2019-07-31 14:22:07 +00:00
Author
Contributor
Copy Link

Folks, I have opened #6 to update the package paths. Once that is merged, I am going to rebase this.

Folks, I have opened https://gitea.com/macaron/session/pulls/6 to update the package paths. Once that is merged, I am going to rebase this.
tamalsaha commented 2019-07-31 23:31:57 +00:00
Author
Contributor
Copy Link

Rebased. PTAL, @lunny.

Rebased. PTAL, @lunny.
lunny approved these changes 2019-08-01 00:13:49 +00:00
Dismissed
lunny closed this pull request 2019-08-01 01:31:19 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
Labels
Clear labels   
kind/breaking

   
kind/bug

   
kind/deployment

   
kind/docs

   
kind/enhancement

   
kind/feature

   
kind/lint

   
kind/proposal

   
kind/question

   
kind/security

   
kind/testing

   
kind/translation

   
kind/ui

   
lgtm/done

   
lgtm/need

   
lgtm/need

   
priority/critical

   
priority/low

   
priority/maybe

   
priority/medium

   
refactor

   
reviewed/duplicate

   
reviewed/invalid

   
reviewed/wontfix

   
status/blocked

   
status/needs-feedback

   
status/wip
No Label
kind/breaking
kind/bug
kind/deployment
kind/docs
kind/enhancement
kind/feature
kind/lint
kind/proposal
kind/question
kind/security
kind/testing
kind/translation
kind/ui
lgtm/done
lgtm/need
lgtm/need
priority/critical
priority/low
priority/maybe
priority/medium
refactor
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
status/blocked
status/needs-feedback
status/wip
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
5 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: macaron/session#4
No description provided.
Delete Branch ":redis-6"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?