adding the ability to override the image completely #534

dgershman · 2023-10-12T00:26:26Z

dgershman commented

2023-10-12 00:26:26 +00:00

First-time contributor

Description of the change

This gives the ability for someone to override the entire image as the image is bound tightly to the image.rootless value.

Benefits

Flexibility to use images that might us a different naming convention.

Possible drawbacks

N/A

Applicable issues

fixes #532

Additional information

⚠ BREAKING

No breaking changes.

Checklist

Parameters are documented in the values.yaml and added to the README.md using readme-generator-for-helm
Breaking changes are documented in the README.md
Templating unittests are added

### Description of the change This gives the ability for someone to override the entire image as the image is bound tightly to the `image.rootless` value. ### Benefits Flexibility to use images that might us a different naming convention. ### Possible drawbacks N/A ### Applicable issues  - fixes #532 ### Additional information  ### ⚠ BREAKING  No breaking changes. ### Checklist  - [x] Parameters are documented in the `values.yaml` and added to the `README.md` using [readme-generator-for-helm](https://github.com/bitnami-labs/readme-generator-for-helm) - [x] Breaking changes are documented in the `README.md` - [ ] Templating unittests are added

dgershman added 2 commits 2023-10-12 00:26:26 +00:00

adding the ability to override the image completely 26996d1098

changing variable name

check-and-test / check-and-test (pull_request) Failing after 21s

Details

75ee965c70

dgershman referenced this pull request

2023-10-12 00:32:44 +00:00

Decouple rootless value from image name generation. #532

justusbunsi requested changes 2023-10-12 04:20:12 +00:00

justusbunsi left a comment

Thanks for opening the PR. Please have a closer look at https://gitea.com/gitea/helm-chart/src/branch/main/unittests/deployment/image-configuration.yaml and add tests for the new option.

pat-s commented

2023-10-12 09:01:15 +00:00

I think

		templates/_helpers.tpl
		Line 64 in 75ee965c70
	
				{{- $rootless := ternary "-rootless" "" (.Values.image.rootless) -}}

must be escaped if fullOverride is defined as it auto-appends -rootless to the image name if .Values.image.rootless = true.

.Values.image.rootless needs to stay as parts of the template are conditioned on it to start a custom SSH server (which is also required for custom images then).

Overall, the whole task might be trickier than it initially seems - but certainly doable :) And yes, probably requires quite some tests.

I think https://gitea.com/gitea/helm-chart/src/commit/75ee965c7083283a25e648c3651c4921c9d2332d/templates/_helpers.tpl#L64 must be escaped if `fullOverride` is defined as it auto-appends `-rootless` to the image name if `.Values.image.rootless = true`. `.Values.image.rootless` needs to stay as parts of the template are conditioned on it to start a custom SSH server (which is also required for custom images then). Overall, the whole task might be trickier than it initially seems - but certainly doable :) And yes, probably requires quite some tests.

pat-s added the

labels 2023-10-12 09:01:38 +00:00

justusbunsi added 1 commit 2023-10-13 16:09:19 +00:00

Merge branch 'main' into feature/image-override

check-and-test / check-and-test (pull_request) Successful in 25s

Details