gitea/tea
gitea/tea
57
130
Fork 64
Code Issues 97 Pull Requests 18 Actions Releases 16 Activity

Add git helper #612

Open
Sirherobrine23 wants to merge 4 commits from Sirherobrine23/tea:main into main
pull from: Sirherobrine23/tea:main
merge into: gitea:main
Conversation 3 Commits 4 Files Changed 7 +190 -6
Sirherobrine23 commented 2023-12-09 18:47:03 +00:00
First-time contributor
Copy Link

Add support to tea login with helper same another tools and gh

Add support to tea login with helper same another tools and `gh`
👍 1
Sirherobrine23 added 1 commit 2023-12-09 18:47:04 +00:00
Add git helper 
Add support to tea login with helper same another tools and `gh`
Co-authored-by: Matheus Sampaio Queiroga <srherobrine20@gmail.com>
Co-committed-by: Matheus Sampaio Queiroga <srherobrine20@gmail.com>
Some checks failed
check-and-test / check-and-test (pull_request) Has been cancelled
Details
6d35e9d762
Sirherobrine23 force-pushed main from 6d35e9d762 to fea1885002 2023-12-09 19:41:19 +00:00 Compare
Sirherobrine23 force-pushed main from fea1885002 to a09ef026ae 2023-12-12 04:19:26 +00:00 Compare
Sirherobrine23 force-pushed main from a09ef026ae to 4e61504a81 2023-12-12 04:30:36 +00:00 Compare
lunny added the
kind
feature
 label 2023-12-12 09:18:58 +00:00
lunny commented 2023-12-12 13:40:26 +00:00
Owner
Copy Link

Will this replace #599 ?

Will this replace #599 ?
Sirherobrine23 commented 2023-12-12 14:12:54 +00:00
Author
First-time contributor
Copy Link

no, it just passes the user and the token for git operations, such as push and pull for authentication, gh also does this for github authentication (gh cli helper)

no, it just passes the user and the token for git operations, such as push and pull for authentication, `gh` also does this for github authentication ([gh cli helper](https://github.com/cli/cli/blob/0f39935cc17c687232776ad4a4db2172559f2a86/pkg/cmd/auth/shared/git_credential.go#L131-L136))
Sirherobrine23 force-pushed main from 4e61504a81 to 9d506745cc 2023-12-27 13:50:18 +00:00 Compare
6543 commented 2024-02-15 14:54:52 +00:00
Owner
Copy Link

please resolve conflicts :)

please resolve conflicts :)
Sirherobrine23 added 1 commit 2024-02-15 17:31:05 +00:00
Merge main
Some checks failed
check-and-test / check-and-test (pull_request) Failing after 23s
Details
1aff5b94f5
Sirherobrine23 force-pushed main from 1aff5b94f5 to 793ecfc288 2024-02-15 17:40:33 +00:00 Compare
Sirherobrine23 force-pushed main from 793ecfc288 to f1d93f21f2 2024-02-15 17:41:50 +00:00 Compare
6543 reviewed 2024-02-15 19:54:26 +00:00
modules/task/login_create.go Outdated
@ -18,0 +22,4 @@
exec.Command("git", "config", "--global", "--unset-all", fmt.Sprintf("credential.%s.helper", login.URL)).Run()
//
_, err := exec.Command("git", "config", "--global", fmt.Sprintf("credential.%s.helper", login.URL), "").Output()
6543 commented 2024-02-15 19:54:26 +00:00
Owner
Copy Link

should this not be a per repo setting?

should this not be a per repo setting?
6543 commented 2024-02-15 19:56:09 +00:00
Owner
Copy Link

ah never mind ... it has to be a global config.

anyway I expect this setup to not delete other helpers

ah never mind ... it has to be a global config. anyway I expect this setup to not delete other helpers
Sirherobrine23 commented 2024-02-15 19:59:59 +00:00
Author
First-time contributor
Copy Link

No, only host set in configuration, if set invalid host git command exit and don't change config

No, only host set in configuration, if set invalid host git command exit and don't change config
6543 marked this conversation as resolved
6543 reviewed 2024-02-15 19:55:22 +00:00
modules/task/login_create.go Outdated
@ -18,0 +21,4 @@
// Remove all helpers
exec.Command("git", "config", "--global", "--unset-all", fmt.Sprintf("credential.%s.helper", login.URL)).Run()
//
6543 commented 2024-02-15 19:55:22 +00:00
Owner
Copy Link

comment = ?!?

comment = ?!?
6543 marked this conversation as resolved
Sirherobrine23 added 1 commit 2024-02-15 20:02:28 +00:00
Update comments
All checks were successful
check-and-test / check-and-test (pull_request) Successful in 50s
Details
ff7b53468f
6543 reviewed 2024-02-15 20:20:30 +00:00
modules/task/login_create.go Outdated
@ -18,0 +19,4 @@
// SetupHelper add tea helper to config global
func SetupHelper(login config.Login) error {
// Remove old helper
exec.Command("git", "config", "--global", "--unset-all", fmt.Sprintf("credential.%s.helper", login.URL)).Run()
6543 commented 2024-02-15 20:20:30 +00:00
Owner
Copy Link

do we have to unset-all others?!?

do we have to unset-all others?!?
Sirherobrine23 commented 2024-02-15 20:31:31 +00:00
Author
First-time contributor
Copy Link

If you run tea login helper setup, it will go through the logins and place a new helper, if you don't delete it it will keep adding the helper, in this case it deletes the other helpers, like it would look like this if you run the command 3 times:

[credential "https://gitea.com"]
	helper = 
	helper = !tea login helper
	helper = !tea login helper
	helper = !tea login helper
If you run `tea login helper setup`, it will go through the logins and place a new helper, if you don't delete it it will keep adding the helper, in this case it deletes the other helpers, like it would look like this if you run the command 3 times: ``` [credential "https://gitea.com"] helper = helper = !tea login helper helper = !tea login helper helper = !tea login helper ```
6543 commented 2024-02-15 20:42:07 +00:00
Owner
Copy Link

could we not just check if there exist an tea entry in this case?

could we not just check if there exist an tea entry in this case?
Sirherobrine23 marked this conversation as resolved
Sirherobrine23 added 1 commit 2024-02-16 00:07:32 +00:00
Check if tea is present in helper
Some checks failed
check-and-test / check-and-test (pull_request) Failing after 22m34s
Details
f9dd53679a
Sirherobrine23 force-pushed main from f9dd53679a to ef9e321c76 2024-02-16 00:16:47 +00:00 Compare
Sirherobrine23 force-pushed main from ef9e321c76 to 9f90b0c053 2024-02-16 00:19:53 +00:00 Compare
All checks were successful
check-and-test / check-and-test (pull_request) Successful in 48s
Required
Details
This pull request doesn't have enough approvals yet. 0 of 1 approvals granted.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u main:Sirherobrine23-main
git checkout Sirherobrine23-main
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
kind/breaking

   
kind/bug

   
kind/build

   
kind/dependency

   
kind/deployment

   
kind/docs
  
kind
enhancement

  
kind
feature

  
kind/proposal
  
kind
question

  
kind
refactor

  
kind/security

   
kind/testing

   
kind/translation

   
priority/critical

   
priority/high

   
priority/low

   
priority/medium

   
reviewed/duplicate

   
reviewed/invalid

   
reviewed/wontfix

   
skip-changelog

   
status/blocked

   
status/has-backport

   
status/has-pull

   
status/needs-backport

   
status/needs-feedback

   
status/needs-reviews

   
status/wip

   
upstream/gitea

   
upstream/sdk
No Label
kind/breaking
kind/bug
kind/build
kind/dependency
kind/deployment
kind/docs
kind
enhancement
kind
feature
kind/proposal
kind
question
kind
refactor
kind/security
kind/testing
kind/translation
priority/critical
priority/high
priority/low
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/has-backport
status/has-pull
status/needs-backport
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
upstream/sdk
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/tea#612
No description provided.
Delete Branch "Sirherobrine23/tea:main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?