macaron/session

Archived

Fix Destroy spelling #7

Merged

lunny merged 1 commits from :fix-destroy into master

2019-08-01 04:54:40 +00:00

tamalsaha commented

2019-08-01 01:51:41 +00:00

Contributor

Signed-off-by: Tamal Saha tamal@appscode.com

Signed-off-by: Tamal Saha <tamal@appscode.com>

tamalsaha commented

2019-08-01 01:54:53 +00:00

Author

Contributor

@lunny , @techknowlogick PTAL 😄

@lunny , @techknowlogick PTAL :smile:

techknowlogick approved these changes 2019-08-01 02:18:00 +00:00

Dismissed

lunny approved these changes 2019-08-01 04:53:59 +00:00

Dismissed

lunny referenced this issue from a commit

2019-08-01 04:54:39 +00:00

Fix Destroy spelling (#7)

lunny closed this pull request

2019-08-01 04:54:40 +00:00

zeripath commented

2019-08-02 18:19:03 +00:00

Contributor

Please note on merge to Gitea we need to update modules/session/virtual.go and modules/session/memory.goto use Destroy rather than Destory.

We might be better off fixing these here though.

It's also worth noting that Destory/Destroy is not called at all in Macaron or Gitea.

Please note on merge to Gitea we need to update `modules/session/virtual.go` and `modules/session/memory.go`to use Destroy rather than Destory. We might be better off fixing these here though. It's also worth noting that Destory/Destroy is not called at all in Macaron or Gitea.

tamalsaha commented

2019-08-02 19:03:20 +00:00

Author

Contributor

Noted, @zeripath !

Noted, @zeripath !

This repo is archived. You cannot comment on pull requests.

No reviewers

No Milestone

No Assignees

4 Participants

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: macaron/session#7

No description provided.